-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maxUtilization field to hash function of BackendService #3938
Conversation
I am not sure if removing default value is going to be a breaking change. It seems that GCP behaves like maxUtilization 0.8 when no maxUtilization is specified in UTILIZATION balancing mode. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @danawillow, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 13 insertions(+), 6 deletions(-)) |
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
I'm not totally sure I understand the purpose of this change. It looks like you don't believe the default for this field should be 0.8, but should instead be 0. Why is that? My impression is that 0.8 is the server-side default, so we set it as the default in the provider so that it shows up in |
When I create a backend service with balancing mode
p.s. the provider doesn't set default p.p.s. We ran into some backend utilization web UI bug recently and I doubt that it might affect backend service in |
Another part of this PR is fixing the hash function. I can separate it into another PR if you think that would be better. |
Hi @danawillow , I removed the commit that removed default value of maxUtilization. Could you review this PR again? Thanks! |
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152331" |
This looks good so far! I just triggered our test pipeline to make sure it passes our existing tests. Can you also modify an existing test (or add a new one) that tests updating this field, since that's what this PR fixes? |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccProviderMeta_setModuleName|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_regionNegBackend You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152336" |
Looks like this failed an existing test:
Let me know if you want some help debugging the failure! |
I have added a new test that tests updating The failed test seems to have something to do with this change. According to @slevenick 's comment here, |
I see. So it sounds like the value is kept in the plan, but removed from the request if it's a NEG. We definitely don't want |
Fixed. Add |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 126 insertions(+), 10 deletions(-)) |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152971" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 123 insertions(+), 10 deletions(-)) |
1 similar comment
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 123 insertions(+), 10 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSpannerInstance_basic|TestAccComputeBackendService_withBackendAndMaxUtilization You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152977" |
fixes hashicorp/terraform-provider-google#7169
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)